Open
Conversation
Owner
|
Thank you very much for submitting this PR, and for making these changes. I have been quite sick lately so I have not had a chance to review yet. I have cloned this to my machine and I will try out your changes and have a look at the architecture with Compose. On first glance, I see that you updated the .gitignore file, which is good, but it seems that many files under app/build are committed. Could you add app/build to the .gitignore file and remove those files from the cache? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the project with an UI in jetpack compose and a "clean architecture". I also replaced the multithreading by coroutines.